ref: Create file io tracker Swift interface #6274

noahsmartin · 2025-09-24T15:31:55Z

Resolves https://linear.app/getsentry/issue/COCOA-709/convert-sentryfileiotracker

#skip-changelog

linear · 2025-09-24T15:31:59Z

codecov · 2025-09-24T15:48:37Z

Codecov Report

❌ Patch coverage is 98.09524% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.849%. Comparing base (f9f21b2) to head (dd45257).
⚠️ Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
Sources/Sentry/SentryFileIOTrackerHelper.m	95.454%	2 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##              main     #6274       +/-   ##
=============================================
+ Coverage   86.768%   86.849%   +0.081%     
=============================================
  Files          440       441        +1     
  Lines        37259     37261        +2     
  Branches     17369     17343       -26     
=============================================
+ Hits         32329     32361       +32     
+ Misses        4886      4858       -28     
+ Partials        44        42        -2

Files with missing lines	Coverage Δ
Sources/Sentry/SentryDependencyContainer.m	`90.041% <100.000%> (+0.329%)`	⬆️
Sources/Sentry/SentryFileIOTrackingIntegration.m	`100.000% <ø> (ø)`
...egrations/Performance/IO/SentryFileIOTracker.swift	`100.000% <100.000%> (ø)`
Sources/Sentry/SentryFileIOTrackerHelper.m	`95.027% <95.454%> (ø)`

... and 40 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9f21b2...dd45257. Read the comment docs.

noahsmartin · 2025-09-25T01:34:32Z

I'm not sure why this only fails to compile for static builds, converting it to draft while I investigate

github-actions · 2025-09-26T00:34:35Z

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1224.06 ms	1256.17 ms	32.11 ms
Size	23.75 KiB	995.08 KiB	971.34 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`6279992`	1213.60 ms	1241.38 ms	27.79 ms
`8bb3e37`	1237.15 ms	1258.33 ms	21.19 ms
`f262e10`	1226.88 ms	1250.39 ms	23.51 ms
`a2a3bfb`	1227.94 ms	1261.26 ms	33.32 ms
`c122943`	1210.94 ms	1233.78 ms	22.84 ms
`59fc426`	1240.49 ms	1256.94 ms	16.45 ms
`13bc1aa`	1244.04 ms	1262.89 ms	18.85 ms
`50a9ff7`	1221.43 ms	1238.07 ms	16.64 ms
`4b3f1af`	1227.04 ms	1253.35 ms	26.31 ms
`41c0aa8`	1222.75 ms	1262.40 ms	39.65 ms

App size

Revision	Plain	With Sentry	Diff
`6279992`	23.75 KiB	891.03 KiB	867.28 KiB
`8bb3e37`	23.75 KiB	968.16 KiB	944.41 KiB
`f262e10`	23.75 KiB	913.62 KiB	889.87 KiB
`a2a3bfb`	23.75 KiB	872.67 KiB	848.92 KiB
`c122943`	23.74 KiB	926.65 KiB	902.90 KiB
`59fc426`	23.75 KiB	920.64 KiB	896.89 KiB
`13bc1aa`	23.75 KiB	908.40 KiB	884.65 KiB
`50a9ff7`	23.75 KiB	913.63 KiB	889.89 KiB
`4b3f1af`	23.75 KiB	981.30 KiB	957.56 KiB
`41c0aa8`	23.75 KiB	986.80 KiB	963.05 KiB

Previous results on branch: fileIOTrackerSwift

Startup times

Revision	Plain	With Sentry	Diff
`9275ca7`	1218.31 ms	1247.20 ms	28.90 ms
`e47cf83`	1215.32 ms	1247.10 ms	31.79 ms
`a3251a5`	1227.13 ms	1258.00 ms	30.87 ms
`53a1477`	1231.23 ms	1264.57 ms	33.34 ms

App size

Revision	Plain	With Sentry	Diff
`9275ca7`	23.75 KiB	981.16 KiB	957.42 KiB
`e47cf83`	23.75 KiB	995.00 KiB	971.25 KiB
`a3251a5`	23.75 KiB	989.12 KiB	965.38 KiB
`53a1477`	23.75 KiB	989.13 KiB	965.38 KiB

Sources/Sentry/include/SentryFileIOTracker.h

philipphofmann

LGTM, when CI is green.

github-actions · 2025-10-13T13:28:42Z

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

Sources/Sentry/SentryUIViewControllerSwizzling.m

noahsmartin requested review from itaybre, philipphofmann and philprime as code owners September 24, 2025 15:31